Comments on: Generic Entity Converter for JSF / Spring / JPA http://www.reverttoconsole.com/blog/jsf/generic-entity-converter-for-jsf-spring-jpa/ for f in *;do echo | sed 'i\rtc' >> $f;done; java programming et al Thu, 19 Jan 2012 04:32:32 +0000 hourly 1 http://wordpress.org/?v=3.3 By: Rusty Wright http://www.reverttoconsole.com/blog/jsf/generic-entity-converter-for-jsf-spring-jpa/comment-page-1/#comment-208 Rusty Wright Tue, 28 Apr 2009 18:23:43 +0000 http://www.reverttoconsole.com/?p=330#comment-208 Oops; the string argument to IllegalArgumentException needs to include String in addition to BaseIdentityEntity. Oops; the string argument to IllegalArgumentException needs to include String in addition to BaseIdentityEntity.

]]> By: Rusty Wright http://www.reverttoconsole.com/blog/jsf/generic-entity-converter-for-jsf-spring-jpa/comment-page-1/#comment-207 Rusty Wright Tue, 28 Apr 2009 18:21:39 +0000 http://www.reverttoconsole.com/?p=330#comment-207 In getAsString() how can the value argument ever be a string? Your first if statement requires it to be BaseIdentityEntity. For me, the code would be clearer if it was along the lines of if (value == null) return ""; if (value instanceof String) return (String) value; if (value instanceof BaseIdentityEntity) { BaseIdentityEntity entity = (BaseIdentityEntity) value; return entity.getId() == null ? "" : entity.getId().toString(); } throw new IllegalArgumentException("This converter only handles instances of BaseIdentityEntity"); In getAsString() how can the value argument ever be a string? Your first if statement requires it to be BaseIdentityEntity. For me, the code would be clearer if it was along the lines of

if (value == null) return “”;
if (value instanceof String) return (String) value;
if (value instanceof BaseIdentityEntity) {
BaseIdentityEntity entity = (BaseIdentityEntity) value;
return entity.getId() == null ? “” : entity.getId().toString();
}
throw new IllegalArgumentException(“This converter only handles instances of BaseIdentityEntity”);

]]>